-
Notifications
You must be signed in to change notification settings - Fork 821
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUG Renable the ability to do dynamic assignment with DBField
- Loading branch information
Maxime Rainville
committed
Feb 21, 2019
1 parent
a481d00
commit 9a59f2f
Showing
6 changed files
with
192 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
tests/php/ORM/DataObjectTest/MockDynamicAssignmentDBField.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
<?php | ||
|
||
namespace SilverStripe\ORM\Tests\DataObjectTest; | ||
|
||
use SilverStripe\ORM\FieldType\DBBoolean; | ||
use SilverStripe\ORM\FieldType\DBField; | ||
|
||
/** | ||
* This is a fake DB field specifically design to test dynamic value assignment. You can set `scalarValueOnly` in | ||
* the constructor. You can control whetever the field will try to do a dynamic assignment by specifing | ||
* `$dynamicAssignment` in nthe consturctor. | ||
* | ||
* If the field is set to false, it will try to do a plain assignment. This is so you can save the initial value no | ||
* matter what. If the field is set to true, it will try to do a dynamic assignment. | ||
*/ | ||
class MockDynamicAssignmentDBField extends DBBoolean | ||
{ | ||
|
||
private $scalarOnly; | ||
private $dynamicAssignment; | ||
|
||
/** | ||
* @param $name | ||
* @param $scalarOnly Whether our fake field should be scalar only | ||
* @param $dynamicAssigment Wheter our fake field will try to do a dynamic assignement | ||
*/ | ||
public function __construct($name = '', $scalarOnly = false, $dynamicAssignment = false) | ||
{ | ||
$this->scalarOnly = $scalarOnly; | ||
$this->dynamicAssignment = $dynamicAssignment; | ||
parent::__construct($name); | ||
} | ||
|
||
/** | ||
* If the field value and dynamicAssignment are true, we'll try to do a dynamic assignement | ||
* @param $value | ||
* @return array|int|mixed | ||
*/ | ||
public function prepValueForDB($value) | ||
{ | ||
if ($value) { | ||
return $this->dynamicAssignment | ||
? ['GREATEST(?, ?)' => [0, 1]] | ||
: 1; | ||
} | ||
|
||
return 0; | ||
} | ||
|
||
public function scalarValueOnly() | ||
{ | ||
return $this->scalarOnly; | ||
} | ||
} |
52 changes: 52 additions & 0 deletions
52
tests/php/ORM/DataObjectTest/MockDynamicAssignmentDataObject.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<?php | ||
|
||
namespace SilverStripe\ORM\Tests\DataObjectTest; | ||
|
||
use SilverStripe\Dev\TestOnly; | ||
use SilverStripe\ORM\DataObject; | ||
use SilverStripe\ORM\ManyManyList; | ||
|
||
/** | ||
* This is a fake DB field specifically design to test dynamic value assignment | ||
* @property boolean $StaticScalarOnlyField | ||
* @property boolean $DynamicScalarOnlyField | ||
* @property boolean $DynamicField | ||
* @method ManyManyList MockManyMany | ||
*/ | ||
class MockDynamicAssignmentDataObject extends DataObject implements TestOnly | ||
{ | ||
|
||
private static $table_name = 'MockDynamicAssignmentDataObject'; | ||
|
||
private static $db = [ | ||
// This field only emits scalar value and will save | ||
'StaticScalarOnlyField' => MockDynamicAssignmentDBField::class . '(1,0)', | ||
|
||
// This field tries to emit dynamic assignment but will fail because of scalar only | ||
'DynamicScalarOnlyField' => MockDynamicAssignmentDBField::class . '(1,1)', | ||
|
||
// This field does dynamic assignement and will pass | ||
'DynamicField' => MockDynamicAssignmentDBField::class . '(0,1)', | ||
]; | ||
|
||
private static $many_many = [ | ||
"MockManyMany" => self::class, | ||
]; | ||
|
||
private static $belongs_many_many = [ | ||
"MockBelongsManyMany" => self::class, | ||
]; | ||
|
||
private static $many_many_extraFields = [ | ||
'MockManyMany' => [ | ||
// This field only emits scalar value and will save | ||
'ManyManyStaticScalarOnlyField' => MockDynamicAssignmentDBField::class . '(1,0)', | ||
|
||
// This field tries to emit dynamic assignment but will fail because of scalar only | ||
'ManyManyDynamicScalarOnlyField' => MockDynamicAssignmentDBField::class . '(1,1)', | ||
|
||
// This field does dynamic assignement and will pass | ||
'ManyManyDynamicField' => MockDynamicAssignmentDBField::class . '(0,1)', | ||
] | ||
]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters