BUG Prevent live manifest loading files from nested test directories

E.g. framework/admin/tests
silverstripe · Mar 31, 2016 · e8a68c4 · e8a68c4
1 parent 78892f0
commit e8a68c4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/core/manifest/ManifestFileFinder.php b/core/manifest/ManifestFileFinder.php
@@ -37,9 +37,8 @@ public function acceptDir($basename, $pathname, $depth) {
 			return false;
 		}
 
-		// If we're not in testing mode, then skip over the tests directory in
-		// the module root.
-		if ($this->getOption('ignore_tests') && $depth == 2 && $basename == self::TESTS_DIR) {
+		// If we're not in testing mode, then skip over any tests directories.
+		if ($this->getOption('ignore_tests') && $basename == self::TESTS_DIR) {
 			return false;
 		}
 

diff --git a/tests/core/manifest/ManifestFileFinderTest.php b/tests/core/manifest/ManifestFileFinderTest.php
@@ -43,7 +43,8 @@ public function testIgnoreTests() {
 
 		$this->assertFinderFinds($finder, array(
 			'module/module.txt',
-			'module/tests/tests.txt'
+			'module/tests/tests.txt',
+			'module/code/tests/tests2.txt'
 		));
 	}
 

diff --git a/tests/core/manifest/fixtures/manifestfilefinder/module/code/tests/tests2.txt b/tests/core/manifest/fixtures/manifestfilefinder/module/code/tests/tests2.txt