Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridFieldExportButton fails on export of large data sets #10195

Closed
mfendeksilverstripe opened this issue Jan 10, 2022 · 1 comment
Closed

GridFieldExportButton fails on export of large data sets #10195

mfendeksilverstripe opened this issue Jan 10, 2022 · 1 comment
Labels
affects/v4 impact/medium type/enhancement

Comments

@mfendeksilverstripe
Copy link
Contributor

mfendeksilverstripe commented Jan 10, 2022 •
edited
Loading

Affected Version

4.x-dev

Description

GridFieldExportButton loads all models into memory when executing export. This is not necessary in case of DataList as we can use generator to load a single model into memory at a time.

For example I have 9000 pages in the export but I'm just exporting IDs and URL segments which results in relatively small export file. This export fails on memory exhaustion.

Steps to Reproduce

Setup a CMS report which yields about 9k records and try to export it via the Export button.

Related Pull requests

#10196
@mfendeksilverstripe mfendeksilverstripe mentioned this issue Jan 10, 2022
Merged
@mfendeksilverstripe
Copy link
Contributor Author

Closing this as the fix was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 impact/medium type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @mfendeksilverstripe