BUG: Export button performance fix. #10196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfendeksilverstripe
force-pushed
the
bugfix/grid-field-export-button
branch
from
42d0e88
to
66722c2
Compare
kinglozzer
approved these changes
Jan 11, 2022
michalkleiner
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Change is looking good.
Can you please amend the commit message to say that it's an enhancement, e.g. "ENH Improve gridfield export pefromance by using DataList generator"? I get the timing-out behaviour seems as a bug, though I still see this as an enhancement, not a change that would be directly adressing a bug. Thank you, Mojmir!
mfendeksilverstripe
force-pushed
the
bugfix/grid-field-export-button
branch
from
66722c2
to
048eb4b
Compare
|
@michalkleiner Thanks for feedback, I've updated the comment as requested ;-), please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Export button performance fix
Memory performance enhancement for
GridFieldexport button.Related issues
#10195