Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: CsvBulkLoader::findExistingObject - support $columnMap #10995

Closed
sabina-talipova opened this issue Oct 17, 2023 · 2 comments
Closed

TODO: CsvBulkLoader::findExistingObject - support $columnMap #10995

sabina-talipova opened this issue Oct 17, 2023 · 2 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

Description

CsvBulkLoader::findExistingObject takes $columnMap as second argument, but method doesn't use it. We should investigate do we still need this argument and if so implement logic to support $columnMap.

See:

silverstripe-framework/src/Dev/CsvBulkLoader.php

Line 292 in cf78a9d

* @todo support $columnMap

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli GuySartorelli mentioned this issue Oct 25, 2023
Open
@GuySartorelli
Copy link
Member

Gonna close this one - there's no clear way to use it there and we aren't likely to get around to investigating this.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@sabina-talipova sabina-talipova mentioned this issue Oct 26, 2023
Open
@sabina-talipova
Copy link
Contributor Author

Open new ticket to remove this argument in CMS6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova