Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better feedback when using CsvBulkLoader #10996

Open
sabina-talipova opened this issue Oct 18, 2023 · 4 comments
Open

Provide better feedback when using CsvBulkLoader #10996

sabina-talipova opened this issue Oct 18, 2023 · 4 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023

Description

We pass message as empty string in BulkLoader_Result::addUpdated from CsvBulkLoader::processRecord (See). We must pass a more clear message to the addUpdated method, or delete this variable from processRecord , since the method addUpdated uses null by default.

See:

Note that this message is (or is supposed to be) displayed in the form modal which is used to trigger the bulk action.

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 25, 2023

@sabina-talipova The description doesn't seem related to the issue title or the links - can you please check this one? I think it got mixed up with #10995

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Oct 26, 2023

Based on your post here.
If we are not going to add support of $columnMap in CsvBulkLoader::findExistingObject, than I think we can close this ticket as well and open another one to remove parameter from both "methods signature".

@GuySartorelli
Copy link
Member

Sounds like a plan

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
@sabina-talipova
Copy link
Contributor Author

Sorry, I copied description from another ticket by accident. I've update description again. I reopen ticket.

@GuySartorelli GuySartorelli changed the title TODO: CsvBulkLoader::processRecord - Better messages for relation checks and duplicate detection Provide better feedback when using CsvBulkLoader Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants