Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The $columnMap argument is no longer required in CsvBulkLoader::findExistingObject #11036

Open
sabina-talipova opened this issue Oct 26, 2023 · 0 comments
Open

The $columnMap argument is no longer required in CsvBulkLoader::findExistingObject #11036

sabina-talipova opened this issue Oct 26, 2023 · 0 comments
Labels
affects/v5 type/api-break
Milestone
Cleanup later

Comments

@sabina-talipova
Copy link
Contributor

Description

CsvBulkLoader::findExistingObject method receives array $columnMap as second argument, but never use it.
We should mark argument $columnMap as deprecated and remove it from the method in version CMS 6. We also should remove this variable everywhere where we invoke CsvBulkLoader::findExistingObject method.

Related issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/api-break
Projects
None yet
Milestone
Cleanup later
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova