Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove path constants references from docs #7075

Closed
chillu opened this issue Jun 28, 2017 · 2 comments
Closed

Remove path constants references from docs #7075

chillu opened this issue Jun 28, 2017 · 2 comments
Labels
affects/v4 complexity/low impact/high type/docs
Milestone
Recipe 4.0.0-rc1

Comments

@chillu
Copy link
Member

chillu commented Jun 28, 2017

After merging #7065, we should no longer teach devs to rely on constants like FRAMEWORK_PATH, or hardcoded paths like Requirements::javascript('mysite/file.js').
@chillu chillu added this to the Recipe 4.0.0-beta2 milestone Jun 28, 2017
@chillu chillu mentioned this issue Jun 28, 2017
Merged
7 tasks
@chillu chillu mentioned this issue Sep 11, 2017
Closed
15 tasks
@chillu
Copy link
Member Author

chillu commented Sep 11, 2017

I've just checked, and there's not a lot of uses any more - it's a handful of FRAMWORK_DIR and FRAMEWORK_PATH

@sminnee
Copy link
Member

sminnee commented Sep 11, 2017

Yeah I did a big blat of this when we introduced Requirements::javascript('silverstripe/framework: client/dist/bundle.js') syntax.

@chillu chillu modified the milestones: Recipe 4.0.0, Recipe 4.0.0-rc1 Oct 6, 2017
tractorcow pushed a commit that referenced this issue Oct 9, 2017
Merge pull request #7444 from open-sausages/pulls/4/fix-docs-paths
5d6a10c 
Fixed docs paths (fixes #7075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/high type/docs
Projects
None yet
Milestone
Recipe 4.0.0-rc1
Development

No branches or pull requests
3 participants
@sminnee @chillu @flamerohr