Form define $fields and $actions as optional but then it throws an error if you don't define them

[maxime-rainville]

Form constructor says it's OK to not specify a $fields and $actions and have them default to null.

However, the first thing it does is try to call setForm on our potentially null values. That's not consistent. Also, setFields() and setActions(), do not do the setForm call.

silverstripe-framework/src/Forms/Form.php

Lines 280 to 290 in 36b1066

	public function __construct(
	RequestHandler $controller = null,
	$name = self::DEFAULT_NAME,
	FieldList $fields = null,
	FieldList $actions = null,
	Validator $validator = null
	) {
	parent::__construct();
	$fields->setForm($this);
	$actions->setForm($this);

Pull Request

• FIX: Fixes #8459 Missing conditionals for optional constructor args #8684

[robbieaverill]

Yeah needs a cheeky if in there really

[phptek]

Cool. Just stumbled into this one too.

[phptek]

See PR at #8683

[EDIT] PR now at #8684 (Fixes missing calls to setForm() as @maxime-rainville pointed out.)