ENH Faster method for creating injected instances

[emteknetnz]

~17% faster method for instantiating things via injector

I validated the performance using the following code in my projects PageController

<?php

use SilverStripe\Admin\ModalController;
use SilverStripe\CMS\Controllers\ContentController;

class PageController extends ContentController
{
    protected function init()
    {
        parent::init();

        $time_pre = microtime(true);
        for($i=0;$i<100000;$i++) {
            //$this->injectOld(); // This took 0.2139 seconds 
            $this->injectNew(); // This took 0.1776 seconds 
        }
        $time_post = microtime(true);
        $exec_time = $time_post - $time_pre;
        echo sprintf("This took %.4f seconds", $exec_time);

    }

    private function injectOld()
    {
        $class = ModalController::class;
        $params = ['MyController', 'MyName'];
        $reflector = new ReflectionClass($class);
        return $reflector->newInstanceArgs($params);
    }

    private function injectNew()
    {
        $class = ModalController::class;
        $params = ['MyController', 'MyName'];
        return new $class(...array_values($params));
    }
}

[kinglozzer]

Nice! I can’t see any reason we would be using Reflection here other than old PHP versions (that we no longer have to support)

[emteknetnz]

@kinglozzer are you happy to re-approve/merge post small change (it's still functionally the same)

[michalkleiner]

Nice!