Allow classes to be passed into Injector::inst()->load() #10539
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Progress on #10533
Summary:
Objective
This PR's purpose is to bring back this functionality, whilst keeping any speed gains from #10265
Spurred off @kinglozzer comments there, and conversation with @GuySartorelli in SS Users slack.
I have tested this locally with business logic, and this resolves the original issue.
Comments
As this adds another path through InjectionCreator it needs some unit tests.
I am not sure where is would be best to add this, doesn't appear to be a dedicated TestInjectionCreator file or anything.
Happy for someone else to write the tests or point me in the right direction.
Parent issue