FIX Use DataColumns content when available in CSV export #10309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes silverstripe#10308)
|
I'm picking that all patches need to be against 4.11 now, to pass testing at least. I've created this pull request against a specific version number, so I'll close it to avoid confusion, and create a new branch and pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9248 broke #9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes #10308)