Allow non summary fields to be used as grid field export fields #9248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @thats4shaw. Would you mind re-targetting the PR against |
Fixes regression in silverstripe@3d989a6.
thats4shaw
force-pushed
the
bugfix/grid-field-export-fields
branch
from
7239bee
to
daf9d55
Compare
|
All done @ScopeyNZ. Thanks for the help! |
ScopeyNZ
approved these changes
Sep 18, 2019
sig-steve
added a commit
to signify-nz/silverstripe-framework
that referenced
this pull request
May 10, 2022
Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes silverstripe#10308)
sig-steve
added a commit
to signify-nz/silverstripe-framework
that referenced
this pull request
May 10, 2022
Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes silverstripe#10308)
sig-steve
added a commit
to signify-nz/silverstripe-framework
that referenced
this pull request
May 10, 2022
Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes silverstripe#10308)
sig-steve
added a commit
to signify-nz/silverstripe-framework
that referenced
this pull request
May 13, 2022
Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes silverstripe#10308)
GuySartorelli
pushed a commit
to GuySartorelli/silverstripe-framework
that referenced
this pull request
Jul 6, 2022
Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a numerically indexed array. Change the check to search the array instead (fixes silverstripe#10308)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in 3d989a6.