Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Support search filters with match_any searchable_fields #10380

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jun 30, 2022

#10199 introduced configuration to allow a single searchable field to search against multiple DB fields - but it doesn't take search filters into account (despite the original documentation including a filter declaration).

This PR updates the match_any functionality to use search filters, and updates documentation.

Indirect parent issue

This property must always have the value 'AND' or an exception will be
thrown - it should be deprecated. Also, no need to process the query
before throwing.
@GuySartorelli GuySartorelli force-pushed the pulls/4/searchable-fields-obey-filters branch from 26142b6 to c562540 Compare June 30, 2022 03:54
@GuySartorelli GuySartorelli changed the base branch from 4 to 4.11 June 30, 2022 03:54
@GuySartorelli GuySartorelli changed the title ENH Support search filters with match_any searchable_fields FIX Support search filters with match_any searchable_fields Jun 30, 2022
@GuySartorelli
Copy link
Member Author

@emteknetnz Retargetted to 4.11 as a bugfix

@GuySartorelli GuySartorelli force-pushed the pulls/4/searchable-fields-obey-filters branch from c562540 to ffcaed8 Compare June 30, 2022 03:56
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green

@GuySartorelli GuySartorelli merged commit 995cc6e into silverstripe:4.11 Jun 30, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/searchable-fields-obey-filters branch June 30, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants