Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH MERGE
Issue silverstripe/gha-ci#37
Includes backport cherry-pick of ec5b94f to fix https://github.com/silverstripe/silverstripe-framework/runs/7441583580?check_suite_focus=true
3) SilverStripe\ORM\Tests\MySQLPDOConnectorTest::testConnectionCharsetControl with data set #1 ('utf8', 'utf8_general_ci', 'utf8_unicode_520_ci')
On
Utf8TestHelper::dbVersion
had to change private?string
property to a mixed var for php 7.3 support, though it's a private on a TestOnly class so it's fine to merge-up