Docs / Tests for Director::absoluteURL #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->assertStringStartsNotWith('javascript', Director::absoluteURL('alert("attack")')); | ||
| $this->assertStringStartsNotWith('alert', Director::absoluteURL('alert("attack")')); | ||
|
|
||
| Director::setBaseURL(false); |
There was a problem hiding this comment.
Is it definitely safe to just reset this to false instead of remembering previous value?
There was a problem hiding this comment.
Setting it to false removes the 'override' ($alternateBaseURL) and reverts to the default behaviour.
There was a problem hiding this comment.
I'll move it to tearDown, which is where it really should be. :)
There was a problem hiding this comment.
Boom, done. At least the environment won't be corrupted if this test case fails.
hafriedlander
pushed a commit
that referenced
this pull request
Apr 7, 2014
Docs / Tests for Director::absoluteURL
|
Thanks @hafriedlander ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hafriedlander