Remove SplitView preview option if the device cannot use it. #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| Subproject commit 6d9b409a80e44438ca78808be26f8602a8a88479 | |||
There was a problem hiding this comment.
Should probably just be included directly rather than using a submodule (especially since there's no .gitmodules)
There was a problem hiding this comment.
Yeah that was a newbie mistake. Good thing the tests did pick this up as well.
…evice has a screen size capable of using it. This uses CSS media queries and will not work with IE8
|
Well, that was a pain in the neck to sort that out.. |
|
Seems to generally work, but if you drag the width of the window to just before the point where the preview frame appears, the "Split view" option still shows. Dragging the window to a much smaller size hides the option, which is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the Split View option in the "Change view mode" menu if the device has a screen width capable of using it. The width is only checked when the CMS initially loads; manually resizing the window afterwards will not disable the option.
This builds on #3291 but adds a js library respond.js to all LeftAndMain admins that is a "polyfill for min/max-width CSS3 Media Queries (for IE 6-8, and more)"