-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Apply psr-2 coding conventions to framework with linting CI check #6340
Conversation
f209b59
to
ea684ae
Compare
PHPCS_TEST is green. :) At least, once I muted all the known broken rules :P |
ea684ae
to
728f80a
Compare
My preference would have been for the whitespace changes to have been applied in their own commit, but it's not a merge blocker if that would be more than an hour's rework. |
All of the automatic fixes are essentially whitespace-only changes. I ran the upgrade again last night with your suggested commands and there was very little difference in output. I don't think phpcbf can easily fix non-whitespace changes without manual input. I may need to double check though. |
The other thing I suggest is setting up a custom script in composer.json so that you can lint by running This will make it easier to lint locally without having to copy/paste a command out of .travis.yml. |
728f80a
to
97d0fc6
Compare
Done, and CI uses the composer script to run linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; let's follow this up with a tests PR.
Initial commit of #6096
Note that all non-automatic fixes have been excluded from this initial build; Manual resolution of all outstanding linting issues are outside of the scope of this introductory pull request.
As requested by @sminnee I've split into two commits, one is an automatic cleanup and the other a linting check.
I have also excluded tests from the current linting, but the plan is to eventually fix and add this folder too.
PHPCS_TEST is run in PHP7 build to ensure optimal coverage of all language constructs.