Updated coding conventions for PSR-2 #6379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged in changes, waiting for tests to finish. |
|
merging in changes ain't the best as they won't be PSR-2? @ingo regarding controller name changes, that's fine IMO we can provide BC through the SiteTree@getControllerName method if we like? You'll need to patch that method, though |
|
I've created a ticket for fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6340
See #6376
I've removed the conventions for underscores in class names (e.g.
Page_Controller), which might be contentious - how are we expecting auto-mapping between page types and their controller in a PSR-2 world?Page=>PageController?