BUG Fix _configure_database.php being ignored #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@tractorcow This is good to merge on green. Just a few seemingly unrelated tests failing? |
tractorcow
force-pushed
the
pulls/4.0/fix-database-config
branch
from
566b6b7
to
ac4991f
Compare
|
Ok, rebased... let's see if this goes green! |
afraid not |
flamerohr
force-pushed
the
pulls/4.0/fix-database-config
branch
from
ac4991f
to
91eb9a6
Compare
tractorcow
force-pushed
the
pulls/4.0/fix-database-config
branch
from
91eb9a6
to
9666222
Compare
|
Rebased and hopefully this will fix it. I had to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7590 and Fixes silverstripe/silverstripe-sqlite3#38
Also deprecates
global $databaseConfigfor _configure_database.php (no longer necessary, but still supported).SQLite3 fix at silverstripe/silverstripe-sqlite3#37