FIX Regression from #8009 #8132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensby
force-pushed
the
pulls/3.5/postgres-test-fix
branch
from
84dd99a
to
bc6589e
Compare
dhensby
force-pushed
the
pulls/3.5/postgres-test-fix
branch
from
bc6589e
to
41e601a
Compare
robbieaverill
approved these changes
Jun 4, 2018
|
Related 4.0 fix: #8150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8041
This fixes the typical sort issue with fetching from postgres DBs
I've replaced the
$this->assertEquals($list->Count(), $listDuplicate->count())with predefined numbers because this helps show what's going on to people reading it and also helps catch regressions.It is expected that if you duplicate both sides of a
ManyManythat you'd get 2 relations where you previously had only 1 and so these changed assertions are correct, the (intermittent) test failures reported in #8009 come from the fact that postgres has unreliable default sorting on objects so the first item wasn't always the one we were asserting against.