Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Fix test that relies on implicit ID order breaking postgres #8150

Merged
merged 2 commits into from
Jun 8, 2018
Merged

BUG Fix test that relies on implicit ID order breaking postgres #8150

merged 2 commits into from
Jun 8, 2018

Conversation

tractorcow
Copy link
Contributor

No description provided.

robbieaverill
robbieaverill reviewed Jun 7, 2018
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar fix for the same thing in 3.5. Worth merging up?

@tractorcow
Copy link
Contributor Author

Merging up from 3.5 to 4.0 is awful.

I've added another commit to fix linting issues.

@chillu chillu merged commit 510b0f7 into silverstripe:4.0 Jun 8, 2018
@chillu chillu deleted the pulls/4.0/fix-postgres-duplication-issue branch June 8, 2018 00:58
@tractorcow
Copy link
Contributor Author

Yay thanks.

@robbieaverill robbieaverill mentioned this pull request Jun 8, 2018
Merged
@robbieaverill
Copy link
Contributor

Cool - related 3.x fix: #8132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill left review comments

Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tractorcow @robbieaverill @chillu