FIX Ensure tests pass by reducing to PHPUnit 7.1.3 #8271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 7.1.4 and higher introduces a bug with float comparisons in strings. The fix until this is resolved is to use PHPUnit 7.1.3. Reference: sebastianbergmann/phpunit#3185 Also updates the phpunit config file to match the schema and imports a missing exception namespace.
robbieaverill
added a commit
to creative-commoners/silverstripe-installer
that referenced
this pull request
Jul 23, 2018
…s in Travis config See silverstripe/silverstripe-framework#8271 for info on the specific PHPUnit version (temporary)
robbieaverill
added a commit
to creative-commoners/silverstripe-installer
that referenced
this pull request
Jul 23, 2018
…s in Travis config See silverstripe/silverstripe-framework#8271 for info on the specific PHPUnit version (temporary)
robbieaverill
added a commit
to creative-commoners/silverstripe-installer
that referenced
this pull request
Jul 23, 2018
…s in Travis config See silverstripe/silverstripe-framework#8271 for info on the specific PHPUnit version (temporary)
|
@maxime-rainville are you sure? I see this for the builds on this branch:
|
maxime-rainville
approved these changes
Jul 24, 2018
robbieaverill
added a commit
to creative-commoners/silverstripe-postgresql
that referenced
this pull request
Aug 17, 2018
|
Gosh, that's a painful regression that you'd think they'd fix a bit more quickly. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 7.1.4 and higher introduces a bug with float comparisons in strings. The fix until this is resolved is to use PHPUnit 7.1.3.
Reference: sebastianbergmann/phpunit#3185
Also updates the phpunit config file to match the schema and imports a missing exception namespace.