Use PHPUnit 7.1.3, update PHPUnit config file schema, quote testsuites in Travis config #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
force-pushed
the
pulls/5.0/update-phpunit
branch
from
f82bd50
to
9d3d628
Compare
|
This does actually get the tests running. The framework PR at silverstripe/silverstripe-framework#8271 would be necessary and there's a couple of other test failures too, but at least they're all running now (previously nothing was actually running at all). |
maxime-rainville
approved these changes
Jul 23, 2018
|
Yep, that's already been done =) I'll rebase this now |
…s in Travis config See silverstripe/silverstripe-framework#8271 for info on the specific PHPUnit version (temporary)
robbieaverill
force-pushed
the
pulls/5.0/update-phpunit
branch
from
b5c7738
to
2dd9d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-framework#8271 for info on
the specific PHPUnit version (temporary)
Hopefully this should get the tests green