Introduce static analysis #9035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Jun 1, 2019
szepeviktor
commented
Jun 1, 2019
| @@ -86,10 +82,6 @@ class DebugView | |||
| 'title' => 'User Deprecated', | |||
| 'class' => 'notice' | |||
| ), | |||
| E_CORE_ERROR => array( | |||
There was a problem hiding this comment.
These 2 are doubles.
|
BTW These are some of the Level 0 errors. Please consider going up to Level 4 (or 7 馃殌) |
|
Hey @szepeviktor, thank you for the pull request! All the changes look good to me, the only thing I'm hesitant about is introducing phpstan. We discussed this last year and at the time decided not to. Moving forwards, it might be worth reopening that RFC again since I think phpstan offers a lot, but for now perhaps you could remove it from composer.json and keep the rest of your changes? Thanks very much! |
This was referenced Jun 3, 2019
|
Case closed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello silverstripers! :)
This is the first round of adding another 100 pair of 馃憖 (phpstan) to your project.
I do like your modern technology but there are dirt spots.
What do you think?