Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce static analysis #9039

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Introduce static analysis #9039

merged 2 commits into from
Jun 3, 2019

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jun 3, 2019 •
edited
Loading

Was #9035, this goes to master, see comments in the other PR.

@szepeviktor szepeviktor mentioned this pull request Jun 3, 2019
Closed
robbieaverill
robbieaverill suggested changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request (SilverStripe specific). Thanks!

src/Control/IPUtils.php Show resolved Hide resolved
robbieaverill
robbieaverill approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 3, 2019 •
edited
Loading

🐴 You're welcome.

@robbieaverill robbieaverill merged commit f45ce20 into silverstripe:master Jun 3, 2019
@robbieaverill robbieaverill mentioned this pull request Jun 4, 2019
Open
@sminnee
Copy link
Member

sminnee commented Jun 4, 2019

We should get this in the 4 branch

@szepeviktor szepeviktor deleted the master-stan branch June 4, 2019 06:27
@sminnee sminnee mentioned this pull request Jul 1, 2019
Closed
@GuySartorelli GuySartorelli mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v5 type/api-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szepeviktor @sminnee @robbieaverill