Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Implement methods in test classes #512

Closed
sabina-talipova opened this issue Oct 11, 2023 · 1 comment
Closed

TODO: Implement methods in test classes #512

sabina-talipova opened this issue Oct 11, 2023 · 1 comment
Labels
affects/v5 type/enhancement New feature or request

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 11, 2023 •
edited
Loading

Description

The following classes have unimplemented methods:

  • SilverStripe\MFA\Tests\Stub\Null\Method
    • getThumbnail
    • applyRequirements
    • getUnavailableMessage
  • SilverStripe\MFA\Tests\Stub\Null\RegisterHandler
    • start
    • register
    • getDescription
    • getSupportLink
    • getSupportText
    • getComponent
  • SilverStripe\MFA\Tests\Stub\Null\VerifyHandler
    • start
    • verify
    • getComponent

We are using these classes only for testing.
@sabina-talipova sabina-talipova mentioned this issue Oct 11, 2023
Closed
@sabina-talipova sabina-talipova mentioned this issue Oct 19, 2023
Merged
@GuySartorelli
Copy link
Member

Given the tests are passing, I'd say it's fine to just leave these unimplemented.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova