Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQLConnector: Return strict PHP types in results #90

Closed
sminnee opened this issue Oct 4, 2018 · 2 comments · Fixed by #91
Closed

PostgreSQLConnector: Return strict PHP types in results #90

sminnee opened this issue Oct 4, 2018 · 2 comments · Fixed by #91

Comments

@sminnee
Copy link
Member

sminnee commented Oct 4, 2018

pg_fieldtype should, in principle, be able to be used to cast boolean, integer, and float values to the correct PHP types.

This affects PostgreSQLConnector but not PGSQL access through PDOConnector.

This will help complete implementation of silverstripe/silverstripe-framework#8448.
@NightJar
Copy link

NightJar commented Oct 4, 2018

This would certainly be ideal, I just ran into this issue today :)

@sminnee
Copy link
Member Author

sminnee commented Oct 4, 2018

The linked framework ticket addresses it in MySQL / PDO code. This would just be the last hurdle.

@sminnee sminnee mentioned this issue Oct 10, 2018
Merged
sminnee pushed a commit that referenced this issue Nov 8, 2018
FIX: Return correct types in PostgreSQLQuery
f094234 
Fixes #90
Helps fix silverstripe/silverstripe-framework#7039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strict types
2 participants
@sminnee @NightJar