Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridField actions should take highest priority in order of screen layout #100

Open
robbieaverill opened this issue May 22, 2018 · 4 comments

Comments

@robbieaverill
Copy link
Contributor

Example:
image

The order of precedence should be:

  • Any alerts for the user
  • The actions toolbar (if one exists) (e.g. GridField actions in this case)
  • Any content

In this case this means moving the report description to a position in between the GridField actions toolbar and the GridField itself.

cc @clarkepaul @newleeland

@clarkepaul
Copy link
Contributor

@newleeland lets go over this tomorrow

@clarkepaul
Copy link
Contributor

From memory there is a Gridfield header which normally sits under the actions (above gridfield), if true then perhaps the Version details should become the header.

@robbieaverill
Copy link
Contributor Author

Thanks @clarkepaul, good to know and I'll add that to the issue for this report - this ticket was more of a core refactoring ticket for future so we can move the description into the right place in the report (ensuring actions are shown first)

@robbieaverill
Copy link
Contributor Author

For information, @ScopeyNZ added a GridFieldHtmlFragment class to allow HTML to be added into the GridField area in the silverstripe-maintenance module. This kind of thing would need to be ported into core to allow us to add report titles and descriptions between the report actions toolbar and the report itself (both GridField and/or components of) since the report title and description are currently FormFields in the FieldList alongside the report's GridField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants