-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference 'sessions' not 'devices' #69
Comments
cc @clarkepaul do you want to chime in with your thoughts on this one? |
If there's a note somewhere at the beginning of the docs about what each of the terms means and that a single device can hold several sessions, then I'd prefer going with sessions wherever possible and contextually correct. |
Referring to "Sessions" makes much more sense for the current functionality we currently have (I think the functionality is fine with a wording change). The easy call to make is changing the label of the section. Just having "Sessions" instead of "Authenticated devices" might be a little abrupt for our audience so playing with a few options, whatever it is I think it should be understandable if you are looking at someone else's sessions too (if devs have provided that extra functionality).
I would have thought it was obvious as to what people should do if they don't recognise a session so I'm a little surprised GitHub explains the area, especially with the audience they have, but then again this is a fairly important section and maybe these types of patterns a more common now than they used to be. The likes of Facebook don't provide any additional info but their label is super easy to understand for non-tech types "Where you're logged in". By simply not using the word "Device" it makes a lot more sense, even if the word "Sessions" wasn't used. |
@clarkepaul I've gone with "Login Sessions" as you've suggested it and it's literally the name of the class that stores the data which will keep developers happy as well. |
Cool, just make sure its lowercase 's' for Login sessions (sentence case) |
Overview
There is some expected overlap between the phrases 'sessions' and 'devices' when looking at this feature. We need to use both terms to paint a clear picture of what's happening. Upon reviewing the current UI, there has been some discussion on tweaking the use of these terms slightly.
At a high-level, it's suggested that we refer to the information and frame it as a 'session', not a 'device' That's also more technically correct given it's the session data that the module is tracking - there's no 'device_ID' for example.
https://invis.io/ANZZEC4XUTQ#/439163639_CMS_-_Login_-_Session_Management_-_Remove_A_Device_-_List
Acceptance Criteria
PRs
Notes
The text was updated successfully, but these errors were encountered: