Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference 'sessions' not 'devices' #69

Closed
3 tasks
brynwhyman opened this issue Apr 27, 2021 · 6 comments · Fixed by #71
Closed
3 tasks

Reference 'sessions' not 'devices' #69

brynwhyman opened this issue Apr 27, 2021 · 6 comments · Fixed by #71

Comments

@brynwhyman
Copy link

brynwhyman commented Apr 27, 2021

Overview

There is some expected overlap between the phrases 'sessions' and 'devices' when looking at this feature. We need to use both terms to paint a clear picture of what's happening. Upon reviewing the current UI, there has been some discussion on tweaking the use of these terms slightly.

At a high-level, it's suggested that we refer to the information and frame it as a 'session', not a 'device' That's also more technically correct given it's the session data that the module is tracking - there's no 'device_ID' for example.

Acceptance Criteria

  • The label in the Profile admin is updated
  • Review existing docs and screenshots that may reference this UI, make necessary changes

PRs

Notes

@brynwhyman
Copy link
Author

cc @clarkepaul do you want to chime in with your thoughts on this one?

@brynwhyman
Copy link
Author

This view from GitHub sparked the conversation:
image

@michalkleiner
Copy link
Contributor

If there's a note somewhere at the beginning of the docs about what each of the terms means and that a single device can hold several sessions, then I'd prefer going with sessions wherever possible and contextually correct.

@clarkepaul
Copy link

Referring to "Sessions" makes much more sense for the current functionality we currently have (I think the functionality is fine with a wording change). The easy call to make is changing the label of the section. Just having "Sessions" instead of "Authenticated devices" might be a little abrupt for our audience so playing with a few options, whatever it is I think it should be understandable if you are looking at someone else's sessions too (if devs have provided that extra functionality).

  1. Active sessions
  2. Login sessions
  3. Device sessions
  4. User sessions
  5. Where you're logged in
  6. Sessions
  7. Logged in

I would have thought it was obvious as to what people should do if they don't recognise a session so I'm a little surprised GitHub explains the area, especially with the audience they have, but then again this is a fairly important section and maybe these types of patterns a more common now than they used to be. The likes of Facebook don't provide any additional info but their label is super easy to understand for non-tech types "Where you're logged in".

By simply not using the word "Device" it makes a lot more sense, even if the word "Sessions" wasn't used.
I think I quite like the simplicity of "Logged in", it makes sense to all user types, and also implies sessions.

@bergice bergice self-assigned this Jun 8, 2021
@bergice bergice removed their assignment Jun 8, 2021
@brynwhyman brynwhyman assigned clarkepaul and bergice and unassigned clarkepaul Jun 8, 2021
@bergice
Copy link
Contributor

bergice commented Jun 8, 2021

Referring to "Sessions" makes much more sense for the current functionality we currently have (I think the functionality is fine with a wording change). The easy call to make is changing the label of the section. Just having "Sessions" instead of "Authenticated devices" might be a little abrupt for our audience so playing with a few options, whatever it is I think it should be understandable if you are looking at someone else's sessions too (if devs have provided that extra functionality).

  1. Active sessions
  2. Login sessions
  3. Device sessions
  4. User sessions
  5. Where you're logged in
  6. Sessions
  7. Logged in

I would have thought it was obvious as to what people should do if they don't recognise a session so I'm a little surprised GitHub explains the area, especially with the audience they have, but then again this is a fairly important section and maybe these types of patterns a more common now than they used to be. The likes of Facebook don't provide any additional info but their label is super easy to understand for non-tech types "Where you're logged in".

By simply not using the word "Device" it makes a lot more sense, even if the word "Sessions" wasn't used.
I think I quite like the simplicity of "Logged in", it makes sense to all user types, and also implies sessions.

@clarkepaul I've gone with "Login Sessions" as you've suggested it and it's literally the name of the class that stores the data which will keep developers happy as well.

@bergice bergice assigned clarkepaul and unassigned bergice Jun 8, 2021
@brynwhyman brynwhyman assigned bergice and unassigned clarkepaul Jun 9, 2021
@clarkepaul
Copy link

Cool, just make sure its lowercase 's' for Login sessions (sentence case)

@emteknetnz emteknetnz removed their assignment Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants