Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG EditableFormHeading doesn't properly handle numeric values #510

Closed
muskie9 opened this issue Sep 21, 2016 · 0 comments
Closed

BUG EditableFormHeading doesn't properly handle numeric values #510

muskie9 opened this issue Sep 21, 2016 · 0 comments

Comments

@muskie9
Copy link
Contributor

muskie9 commented Sep 21, 2016

There seems to be a bug with EditableFormHeading where passing a value such as 2016 is actually rendered as the generated field name, for example something like EditableTextField_f157b. I've tracked this back to the way HeaderField works in framework's HeaderField and how EditableFormHeading passes the values to the HeaderField created.

I've traced this as far back as framework 3.1.x-dev with userforms 3.0.x-dev. I haven't completely uncovered the underlying issue why integer values aren't rendered are affected, but my fix seems to work with both integers and strings. I'll have a PR against the 3.0.x-dev branch and can re-submit if needed against another branch if that is too far back. I may need some help with tests if those are required for the PR but I didn't see any existing tests for this particular class.

dhensby added a commit that referenced this issue Sep 23, 2016
BUGFIX EditableFormHeading doesn't properly handle numeric values
scott1702 pushed a commit to torque-foxes/silverstripe-userforms that referenced this issue Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant