Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in translation key #1241

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix typo in translation key #1241

merged 1 commit into from
Sep 20, 2023

Conversation

baukezwaan
Copy link
Contributor

Minor typo, causing translation of string to fail

(retry of PR #1238 )

@baukezwaan
Copy link
Contributor Author

Easiest will be to allow maintainers to modify your branch (I don't know where the setting for that is after you've created a PR though) - and then Michal can update it from his fork (you will still be credited for your change)

Tried to instantly enable the option to 'allow maintainers to edit', but can't find the option unfortunately. Also checked these steps

@baukezwaan baukezwaan marked this pull request as ready for review September 20, 2023 07:17
@michalkleiner michalkleiner merged commit f7d2d47 into silverstripe:5.15 Sep 20, 2023
12 checks passed
@GuySartorelli GuySartorelli mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baukezwaan @michalkleiner