-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in translation key #1238
Conversation
…upgrade-cms5 DEP PHP Support in CMS5
…broken-builds MNT Broken builds
…remove-legacy-upgrader MNT Remove legacy upgrader config
…broken-builds MNT Broken builds
…php82 MNT Unit test PHP 8.2 compatibility
…dispatch-ci MNT Use gha-dispatch-ci
…0/devjs MNT Update dev JS
…0/cms5-readme DOC Update README.md for CMS 5
…0/module-standardiser-1693279088 MNT Run module-standardiser
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@baukezwaan this would be best targeted at the minor version that introduced the change, if we target 5 the fix won't meet the bug for the current minor. |
There are a lot of commits here that aren't related to the change you're trying to make - presumably carried over from retargetting the PR. Please reset the PR so that only your commits are reflected here. |
# Conflicts: # tests/php/Model/SubmittedFileFieldTest.php
@GuySartorelli would love to do it, but can't figure out how to do that... |
@baukezwaan if you enable updates by maintainers I can fix the branch for you, but at the moment I can't push to it. |
I've fixed the branch and it's on my fork for now https://github.com/michalkleiner/silverstripe-userforms/tree/fix_translation_key |
@baukezwaan Thanks for giving it a go - there are a few ways to proceed from here.
|
Thanks @michalkleiner and @GuySartorelli for the feedback, I will save these to my notes for future reference. I will close this PR, since @michalkleiner has a clean PR now. |
@baukezwaan I don't think @michalkleiner created a PR - rather, I think he just prepared the changes required to update this PR, and was waiting for you to open it up for him to edit. |
Unfortunately reopening is not an option, since it was recreated |
For future reference, see #1241 for the replacement PR |
Minor typo, causing translation of string to fail