Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

u16 is too small for ChangeInfo.insertions and ChangeInfo.deletions #30

Open
dekobon opened this issue Mar 1, 2019 · 0 comments
Open

Comments

@dekobon
Copy link

dekobon commented Mar 1, 2019

I hit a bug where libgerrit was unable to deserialize the response from gerrit due to the amount of insertions being higher than u16. Using a u32 for this value would better serve users of the library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant