New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #101, install includes to simbody subfolder #102
Conversation
Install header files to simbody subfolder to prevent mixing with other system header files.
Steve, I think this breaks the Windows installation. There the standard is to install everything under a product directory, so the installation goes into simbody/include rather than include/simbody. There are really two styles of installation that have to coexist, on various platforms:
I really don't have a clear picture of how this is supposed to work. For years I have used a dumb approach that worked on every platform -- "make install" would put all the files under a common |
The rationale behind the Linux multiple destinations comes from Linux FHS (Filesystem Hierarchy Standard). In some way you can still installing all under a single directory if you use the Just a reminder that for getting simbody into main Linux distribution, the FHS is a must. |
I just updated the pull request to fix the Win32 installation. @sherm1 can you test it again? |
Will do. Thanks, Steve. |
Looks good on Windows (64 bit). I noticed that the CMake config file is in lib/cmake/*.config. That seems a little buried but I don't really know where to put it. |
PS I haven't tested this on Mac or Linux. |
I tested it on mac and linux, so I think we're ok in terms of the header file locations. I just read up on where the cmake config files need to be in the cmake documentation. Apparently, the current location looks to be incorrect for Windows. Here is the list of valid locations for Windows:
and here is the list for Unix:
I'll make another pull request to fix the cmake config location for Windows. EDIT: #107 |
Install header files to simbody subfolder to prevent mixing
with other system header files. Fixes #101.