Minor modifications to get simbody-3.5 to compile with Visual Studio 2015. #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherm1
added a commit
that referenced
this pull request
Jun 14, 2015
Minor modifications to get simbody-3.5 to compile with Visual Studio 2015.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue is that Microsoft added a definition of "struct timespec" to time.h which conflicted with the one we were defining.
There is a potential problem with timespec-related functions in our fake pthread implemention since the new Microsoft definition isn't identical to the one in the pthread library. I'm not sure that we are using those anywhere however.
Same as master branch PR #394 except attempts to preserve C++03 compatibility.