Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building simbody as cmake subproject #721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sradler
Copy link

@sradler sradler commented Sep 14, 2021

This change is Reviewable

Copy link

@halleysfifthinc halleysfifthinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Simbody is a subproject, CMAKE_SOURCE_DIR is the directory of the top-level project, and paths in simbody's CMakeLists.txt (e.g. on lines 669, 700, and 717) that assume CMAKE_SOURCE_DIR is the simbody source directory will be incorrect.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halleysfifthinc can you confirm that this PR is sufficient to address the problem? If so I'll merge it.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sradler)

@halleysfifthinc
Copy link

This allows Simbody to build correctly as a subproject, but there are still some other changes (global CACHE variables described in #789) that are needed to make Simbody play nice as a subproject. I think those other changes would best be addressed in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants