Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port drive subsystem to command robot #8

Closed
colemacphail opened this issue Nov 8, 2023 · 2 comments · Fixed by #58
Closed

Port drive subsystem to command robot #8

colemacphail opened this issue Nov 8, 2023 · 2 comments · Fixed by #58
Assignees
@IanTapply22
Labels
enhancement New feature or request high priority This is a high priority issue release critical This feature or bug needs to be merged before we release this project publicly
Milestone
Porting 2023 Code

Comments

@colemacphail
Copy link
Member

colemacphail commented Nov 8, 2023 •
edited by IanTapply22
Loading

Maybe a big ticket

  • Create commands for each state
  • Bind triggers to each command

Time Estimate: 6 hours
@IanTapply22 IanTapply22 added the high priority This is a high priority issue label Nov 11, 2023
@colemacphail colemacphail added this to the Porting 2023 Code milestone Nov 11, 2023
@IanTapply22 IanTapply22 added the enhancement New feature or request label Nov 12, 2023
@IanTapply22 IanTapply22 mentioned this issue Nov 12, 2023
Closed
@colemacphail colemacphail mentioned this issue Nov 12, 2023
Closed
@IanTapply22
Copy link
Member

Blocked while waiting for #38 to be merged

@IanTapply22
Copy link
Member

Unblocked, we're just going to rely on the motors. Apparently with the falcons there is a flaw with the sensors, so this year will be a lot better for driving.

@IanTapply22 IanTapply22 added the release critical This feature or bug needs to be merged before we release this project publicly label Dec 18, 2023
@IanTapply22 IanTapply22 mentioned this issue Jan 4, 2024
Merged
8 tasks
@IanTapply22 IanTapply22 linked a pull request Jan 4, 2024 that will close this issue
Port drive subsystem to command robot #58
Merged
8 tasks
kaleb-dodd pushed a commit that referenced this issue Jan 6, 2024
Port drive subsystem to command robot (#58)
b269ec6 
# Description

- Updated the drive-related dependencies to the latest beta
- Updated drive telemetry to the new CTRE suggested way
- Created a new drive subsystem and deleted the old one

Fixes #8 

## Type of change

- [x] New feature (non-breaking change which adds functionality)

# How Has This Been Tested?
N/A

# Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation, if any
- [ ] My changes generate no new warnings
- [ ] I have performed tests that prove my fix is effective or that my
feature works, if necessary
- [ ] New and existing unit tests pass locally with my changes

---------

Co-authored-by: github-actions <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanTapply22 IanTapply22

Labels
enhancement New feature or request high priority This is a high priority issue release critical This feature or bug needs to be merged before we release this project publicly
Projects
None yet
Milestone
Porting 2023 Code
Development

Successfully merging a pull request may close this issue.

Port drive subsystem to command robot Simbotics/Simbot-Base
4 participants
@colemacphail @kaleb-dodd @Hannah8765 @IanTapply22