Loading NetTool spam on main menu

[Archomeda]

It would seem that PrecisionEngineering has some problems in combination with Traffic Manager in an odd way:

1. Start the game
2. Go to the map or asset editor
3. After loading, go to the main menu again
4. Now PrecisionEngineering spams the log with: [PrecisionEngineering] Loading NetTool thousands of times

Consequences of this bug, is that the fps drops significantly over time in the main menu when this is happening (perhaps because of all that loading?). Another thing to add, is that when this is happening, and you happen to open a window in the main menu (e.g. new game, tools, content manager, etc.) and try to close that, it throws the following exception without allowing me to close the window:

NullReferenceException
at (wrapper managed-to-native) UnityEngine.Behaviour.get_enabled () <0x00075>
at ColossalFramework.UI.UIComponent.get_isEnabled () <0x0001c>
at ColossalFramework.UI.UIComponent.Focus () <0x0005a>
at ColossalFramework.UI.UIView.PopModal (int) <0x001aa>
at ColossalFramework.UI.UIDynamicPanels.Hide (string,int) <0x000f3>
at LoadSavePanelBase`1.OnClosed () <0x0006e>
at (wrapper dynamic-method) object.DynamicEventWrapper_OnClosed (NewGamePanel,ColossalFramework.UI.UIComponent,ColossalFramework.UI.UIMouseEventParameter) <0x00018>
at ColossalFramework.UI.UIComponent.OnClick (ColossalFramework.UI.UIMouseEventParameter) <0x000c8>
at ColossalFramework.UI.UIButton.OnClick (ColossalFramework.UI.UIMouseEventParameter) <0x0027f>
at ColossalFramework.UI.UIInput/MouseHandler.ProcessInput (ColossalFramework.UI.IInputTranslator,UnityEngine.Ray,ColossalFramework.UI.UIComponent,bool) <0x00bd1>
at ColossalFramework.UI.UIInput.ProcessMouseInput () <0x002ba>
at ColossalFramework.UI.UIInput.Update () <0x00055>


(Filename:  Line: -1)

Trying to close it the second time seems to work though and prevents the exception from happening again.

I hope you can replicate the issue. I've nailed it down to Precision Engineering and Traffic Manager. Without Traffic Manager, Precision Engineering works fine.

[Simie]

Hi Archomeda, thanks for the detailed report. I'll take a closer look when I have some free time to work on the mod.

[Simie]

It is a bug with Traffic Manager, I believe. It's throwing an exception in the OnLevelUnloaded callback which is preventing Precision Engineering from receiving that event. I've reported it on their github page. SvetlozarValchev/Skylines-Traffic-Manager#13

[Archomeda]

Thanks for investigating it further, and also for forwarding it 😄
This sounds very possible, considering Precision Engineering works fine without Traffic Manager. I just didn't know whether it was a fault from your side, or theirs.
Anyway, I'm sure it will get fixed some day. It's not a huge bug, just more of an annoyance.

Well, thanks again! Your mod is really awesome 👍
Take care!

[Simie]

No problem, and thanks! I'm glad you enjoy the mod! 😄