Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple sources for applications #1

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Multiple sources for applications #1

wants to merge 55 commits into from

Conversation

similark
Copy link

@similark similark commented Dec 7, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

dependabot bot and others added 12 commits December 5, 2022 08:38
@dependabot
chore(deps): bump github.com/valyala/fasttemplate from 1.2.1 to 1.2.2 (…
ac71ec8 
…argoproj#11552)

Bumps [github.com/valyala/fasttemplate](https://github.com/valyala/fasttemplate) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/valyala/fasttemplate/releases)
- [Commits](valyala/fasttemplate@v1.2.1...v1.2.2)

---
updated-dependencies:
- dependency-name: github.com/valyala/fasttemplate
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/ktrysmt/go-bitbucket from 0.9.40 to 0.9.…
44a4ec1 
…54 (argoproj#11554)

Bumps [github.com/ktrysmt/go-bitbucket](https://github.com/ktrysmt/go-bitbucket) from 0.9.40 to 0.9.54.
- [Release notes](https://github.com/ktrysmt/go-bitbucket/releases)
- [Commits](ktrysmt/go-bitbucket@v0.9.40...v0.9.54)

---
updated-dependencies:
- dependency-name: github.com/ktrysmt/go-bitbucket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/imdario/mergo from 0.3.12 to 0.3.13 (arg…
cbb4303 
…oproj#11555)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.12 to 0.3.13.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@0.3.12...v0.3.13)

---
updated-dependencies:
- dependency-name: github.com/imdario/mergo
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@siliconsheep
docs: update how to access arrays in Go templates (argoproj#11562)
89792b4 
Signed-off-by: Dieter Bocklandt <dieterbocklandt@gmail.com>

Signed-off-by: Dieter Bocklandt <dieterbocklandt@gmail.com>
@Frapschen
add otel interceptor (argoproj#11561)
f25f0b2 
Signed-off-by: minquan.chen <minquan.chen@daocloud.io>

Signed-off-by: minquan.chen <minquan.chen@daocloud.io>
@the-technat
fix: use repository GithubAppCreds proxy if set (argoproj#11422)
5bb937c 
Signed-off-by: Nathanael Liechti <technat@technat.ch>

Signed-off-by: Nathanael Liechti <technat@technat.ch>
@alexef
feat: show app age in application list view (argoproj#11209) (argopro…
cf7bf14 
…j#11502)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@ashutosh16 @rbreeze
fix: sidebar css (argoproj#11531)
d269988 
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
@the-technat
feat: Allow proxy to be saved when creating repoCreds (argoproj#11351) (
4018fd8 
argoproj#11425)

* fix: allow proxy to be saved in repoCreds (https + github app)

Signed-off-by: Nathanael Liechti <technat@technat.ch>

* chore: changes from codegen

Signed-off-by: Nathanael Liechti <technat@technat.ch>

* chore: add unit test for CreateRepoCreds

Signed-off-by: Nathanael Liechti <technat@technat.ch>

Signed-off-by: Nathanael Liechti <technat@technat.ch>
@dependabot
chore(deps): bump github.com/go-openapi/runtime from 0.19.4 to 0.25.0 (…
507bd9d 
…argoproj#11568)

Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.19.4 to 0.25.0.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](go-openapi/runtime@v0.19.4...v0.25.0)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@michaelvl
docs: Add skipCrds and ignoreMissingValueFiles to application.yaml ex…
2e9f573 
…ample (argoproj#11565)
@apsega
chore: add Vinted to users list (argoproj#11214)
434f35e 
Signed-off-by: Edgaras <edgaras@apsega.lt>

Signed-off-by: Edgaras <edgaras@apsega.lt>
@similark similark force-pushed the multiple-sources-for-applications branch from 2550c0d to cb28d36 Compare December 7, 2022 13:24
dependabot bot and others added 17 commits December 7, 2022 11:03
@dependabot
chore(deps): bump sigs.k8s.io/structured-merge-diff/v4 (argoproj#11580)
5a8f64b 
Bumps [sigs.k8s.io/structured-merge-diff/v4](https://github.com/kubernetes-sigs/structured-merge-diff) from 4.2.1 to 4.2.3.
- [Release notes](https://github.com/kubernetes-sigs/structured-merge-diff/releases)
- [Changelog](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/structured-merge-diff@v4.2.1...v4.2.3)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/structured-merge-diff/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/go-openapi/loads from 0.19.4 to 0.21.2 (a…
c9f5465 
…rgoproj#11569)

Bumps [github.com/go-openapi/loads](https://github.com/go-openapi/loads) from 0.19.4 to 0.21.2.
- [Release notes](https://github.com/go-openapi/loads/releases)
- [Commits](go-openapi/loads@v0.19.4...v0.21.2)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/loads
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexef
fix(helm): helm v3 doesn't have these flags (argoproj#11100) (argopro…
6ecd70a 
…j#11540)

* fix: helm v3 doesn't have these flags

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Revert repoAdd change. Was to greedy, ca-file is needed there

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef
fix(helm): login OCI Helm dependencies correctly (argoproj#8563) (arg…
13dd04f 
…oproj#11327)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef
fix: misc css fixes for mobile (argoproj#5705) (argoproj#11508)
30e37b7 
* Misc css fixes for mobile

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* More fixes for mobile

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* fix ui tests. bring back application status labels

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@gdsoumya
feat: added deep links backend changes (argoproj#11401)
661afe0 
* feat: added deep links backend changes

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* fix: add rbac check to list links services

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: removed project param and updated sample config

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update sample config

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@dependabot
chore(deps): bump github.com/Masterminds/semver/v3 from 3.1.1 to 3.2.0 (
6c5da3f 
argoproj#11605)

Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/Masterminds/semver/releases)
- [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md)
- [Commits](Masterminds/semver@v3.1.1...v3.2.0)

---
updated-dependencies:
- dependency-name: github.com/Masterminds/semver/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/go-redis/redis/v8 from 8.11.3 to 8.11.5 (a…
74798a6 
…rgoproj#11606)

Bumps [github.com/go-redis/redis/v8](https://github.com/go-redis/redis) from 8.11.3 to 8.11.5.
- [Release notes](https://github.com/go-redis/redis/releases)
- [Changelog](https://github.com/go-redis/redis/blob/v8.11.5/CHANGELOG.md)
- [Commits](redis/go-redis@v8.11.3...v8.11.5)

---
updated-dependencies:
- dependency-name: github.com/go-redis/redis/v8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/casbin/casbin/v2 from 2.57.1 to 2.59.0 (a…
9ceef4a 
…rgoproj#11607)

Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.57.1 to 2.59.0.
- [Release notes](https://github.com/casbin/casbin/releases)
- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)
- [Commits](casbin/casbin@v2.57.1...v2.59.0)

---
updated-dependencies:
- dependency-name: github.com/casbin/casbin/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cuong-ts
chore: add Trusting Social users list (argoproj#11584)
4462deb 
* Add Trusting Social user

Signed-off-by: Cuong Nguyen Duc <90603605+cuong-ts@users.noreply.github.com>

* fixing other

Signed-off-by: Cuong Nguyen Duc <90603605+cuong-ts@users.noreply.github.com>
@fty4
fix: set baseURL in github_app client (argoproj#11613)
a3a3e8d 
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
@fty4 @crenshaw-dev
fix: only add baseURL in github_app client for GHE client (argoproj#1…
07c0ee5 
…1622)

fixes argoproj#11613

Co-authored-by: crenshaw-dev <crenshaw-dev@users.noreply.github.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Co-authored-by: crenshaw-dev <crenshaw-dev@users.noreply.github.com>
@ishitasequeira
feat: support multiple sources for application
b414cb7 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

remove debug logging and unwanted code

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix lint and unit test errors

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix lint and unit test errors

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fix bug introduced after rebase
74e951b 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

executed make codegen

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
rebase with master
7972f8c 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

remove unwanted logging

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix ci failures

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fix index out of bounds error
120d645 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
ui fixes
1096025 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
ishitasequeira and others added 24 commits December 9, 2022 03:24
@ishitasequeira
add revisions to SyncOperation for rollback
c36d4a6 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fix ui failures
2f70ce5 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fixing lint errors
196fe01 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
Retrigger CI pipeline
dac9c5e 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
ui fixes
5191312 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
change Source to *ApplicationSource in ApplicationSpec
832c660 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fix UI errors
56454eb 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
address PR comments
2b57a15 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
Retrigger CI pipeline
6c2a49e 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
rebased with master
70de2fc 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fix env variable read logic for ValueFiles
b299dbe 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
Address PR comments
0176ccb 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
fix lint
a40b60e 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
update multiple sources doc
e1d629b 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
add repository lock and checkout target revision
61de05e 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix codegen

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
checkout all sources before generating manifest
8bc7db9 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
generate mock reposerverclient
0da205c 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
address comments
a5e1430 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
update logic for returning ManifestResponse to avoid nil pointer issues
d1e624d 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@crenshaw-dev @ishitasequeira
fix nil reference and key mismatch bugs; add more logs (argoproj#6)
305ee3b 
* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (argoproj#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira
update grpc field numbers
8172df8 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@crenshaw-dev
path resolution tests (argoproj#12)
cf244ef 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

do things in better ways

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

consolidate

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@ishitasequeira
add regex check for value of source.ref
c8d624b 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
updated version to test multiple sources
f89a67d
@similark similark force-pushed the multiple-sources-for-applications branch from fc2939f to f89a67d Compare December 11, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone