Modifiers replaced by stacking should not trigger a ModifierRemoved event

[unleashurgeek]

In the current sim implementation, ReplaceBySource and Replace stacking behaviors will trigger a ModifierRemoved event and call the OnRemove listener when being replaced (IE: another application is occurring). This results in any removal behavior being triggered:

srsim/pkg/engine/modifier/add.go

Lines 111 to 139 in 3f1c354

	func (mgr *Manager) replaceBySource(target key.TargetID, instance *ModifierInstance) (*ModifierInstance, bool) {
	for i, mod := range mgr.targets[target] {
	if mod.name == instance.name && mod.source == instance.source {
	// replace means this added instance is the new instance (can have new param values)
	instance.count = stackCount(instance, mod.count)
	mgr.targets[target][i] = instance
	mgr.emitRemove(target, []*ModifierInstance{mod})
	return instance, true
	}
	}
	// no match, add this instance as a new modifier
	mgr.targets[target] = append(mgr.targets[target], instance)
	return instance, true
	}
	func (mgr *Manager) replace(target key.TargetID, instance *ModifierInstance) (*ModifierInstance, bool) {
	for i, mod := range mgr.targets[target] {
	if mod.name == instance.name {
	// replace means this added instance is the new instance (can have new param values)
	instance.count = stackCount(instance, mod.count)
	mgr.targets[target][i] = instance
	mgr.emitRemove(target, []*ModifierInstance{mod})
	return instance, true
	}
	}
	// no match, add this instance as a new modifier
	mgr.targets[target] = append(mgr.targets[target], instance)
	return instance, true
	}

This does not match the game behavior. In-game, these replace stacking/refresh scenarios do not cause a removal to be triggered. These emitRemove calls should be removed from these stacking behaviors