switch back to library ids for all interactions; omit type when adding [

#35 #20]

src/js/googlemusic.js

@@ -190,7 +190,9 @@ function addTracks(userIndex, playlistId, tracks, callback, onError) {
   // [["<sessionid>",1],["<listid>",[["<store id or songid>",tracktype]]]]
   const payload = [['', 1],
     [
-      playlistId, tracks.map(t => [Track.getPlaylistAddId(t), t.type]),
+      // Google always sends [id, type] pairs, but that's caused problems for me around AA and store ids and types.
+      // Just sending an id seems to work, so maybe that'll fix everything?
+      playlistId, tracks.map(t => [t.id]),
     ],
   ];
   authedGMRequest('addtrackstoplaylist', payload, userIndex, 'post', response => {
@@ -268,18 +270,18 @@ exports.setPlaylistContents = function setPlaylistContents(db, userIndex, playli
       const idsToAdd = {};
       for (let i = 0; i < tracks.length; i++) {
         const track = tracks[i];
-        idsToAdd[Track.getPlaylistAddId(track)] = track;
+        idsToAdd[track.id] = track;
       }
 
       const deleteCandidates = {};
       for (let i = 0; i < contents.length; i++) {
         const remoteTrack = contents[i].track;
         const entryId = contents[i].entryId;
 
-        if (!(Track.getPlaylistAddId(remoteTrack) in idsToAdd)) {
+        if (!(remoteTrack.id in idsToAdd)) {
           deleteCandidates[remoteTrack.id] = entryId;
         } else {
-          delete idsToAdd[Track.getPlaylistAddId(remoteTrack)];
+          delete idsToAdd[remoteTrack.id];
         }
       }
 

src/js/track.js

@@ -89,18 +89,6 @@ exports.fromJsproto = function fromJsproto(jsproto) {
   return track;
 };
 
-exports.getPlaylistAddId = function getPlaylistAddId(track) {
-  // Return the id for this track when interacting with Google.
-  // For some reason Google doesn't accept AA playlist adds with library ids.
-  let id = track.id;
-
-  if (track.type === 7) {
-    id = track.storeId;
-  }
-
-  return id;
-};
-
 exports.toString = function toString(track) {
   let output = '';
   for (const key in track) {