Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Before/After X days ago #56

Closed
yinka opened this issue Apr 8, 2016 · 7 comments
Closed

Before/After X days ago #56

yinka opened this issue Apr 8, 2016 · 7 comments

Comments

@yinka
Copy link

yinka commented Apr 8, 2016

Thank you so much for this extension.

I am a little bit confused by the use of before/after in dates like below: (sorry if this is obvious)

Last Played : Before : 15 Days Ago (described as lastPlayed < 15 days ago)

Last Played : After : 15 Days Ago (described as lastPlayed > 15 days ago)

I will be grateful if you provide a brief explanation.

@yinka yinka changed the title Before/After : X days ago Before/After X days ago Apr 8, 2016
@simon-weber
Copy link
Owner

Haha, no worries; someone else asked about this previously as well. Check out this explanation and let me know if it clears it up: #35 (comment).

If so, I'll clean it up, move it to the faq and link it from the editor. Or, maybe there's a better way to name it that removes the ambiguity? I'd love to hear your thoughts how you'd naturally think about this.

@PeteRepeat77
Copy link

Can you change the wording to "Within" rather than before, and "More than" for after? Or are there other arguments that rely on "before"

Or did I get these backwards again ha ha

@PeteRepeat77
Copy link

Actually if last played is less than 15 days ago, then that means it was played a long time ago... So when I change the way I think about it all is good but I think within and more than makes more sense to me.

@yinka
Copy link
Author

yinka commented Apr 8, 2016

Hi Simon

Thanks for the quick reply and for the link - it helped.

Could you add a date picker to differentiate relative and absolute date:

Last Played : Before : 31/02/2015

Date Added to Library : 30 days ago

Date Added to Library : yesterday

This will give users 2 time format options:

  • without before/after - intelligent parsing you already implemented like 30 days ago , yesterday or
  • with before/after - absolute date using a date_picker.

The form field UI will still be the same with maybe a visual cue in the form of a calendar icon like below:

image

Thanks and well done.

@simon-weber
Copy link
Owner

a date picker to differentiate relative and absolute date...

It's not clear since there's no example, but absolute datetimes will be parsed currently. I'd like to avoid changing the interface much since it's generated by third party code that's a pain to work with 😁

I think phrasing this more like a time range might be the way to go. What about rewording to "between now and" and "earlier than"?

This reads pretty well to me for all the cases:

  • recently added:
    • date added to library between now and 30 days ago
    • date added to library between now and april 1 2016
  • not heard recently:
    • last played earlier than april 1 2016
    • last played earlier than 30 days ago

We'd also want to add an absolute datetime example to the page.

@yinka
Copy link
Author

yinka commented Apr 9, 2016

That should make it clearer, thanks

@simon-weber
Copy link
Owner

Thanks for the feedback!

@simon-weber simon-weber removed their assignment Apr 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants