Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

guarantee correct remote ordering with sort/limit #9

Closed
simon-weber opened this issue Nov 24, 2015 · 3 comments
Closed

guarantee correct remote ordering with sort/limit #9

simon-weber opened this issue Nov 24, 2015 · 3 comments

Comments

@simon-weber
Copy link
Owner

Currently, remote playlists are handled like a set: when we update, we add and delete the minimum amount of tracks to result in the desired tracks. This doesn't respect the desired ordering, but does result in the correct tracks.
@simon-weber simon-weber mentioned this issue Nov 25, 2015
Closed
simon-weber added a commit that referenced this issue Nov 26, 2015
@simon-weber
support sort and limit [#9]
a82dace 
serverside sorting will only work for newly-created playlist because of
the idempotent delete/add sync. I remember reordering being a total pita
in gmusciapi, so we may want to just delete and add every time?
@simon-weber
Copy link
Owner Author

See long comment of a82dace -- we'll either need reorder support, or always delete/add.

@simon-weber
Copy link
Owner Author

Actually, delete/add probably won't work given how Google partially updates (it's unlikely that partial updates are handled in order).

@simon-weber simon-weber changed the title add support for sort order and limit guarantee correct remote ordering with sort/limit Nov 27, 2015
@simon-weber simon-weber mentioned this issue Nov 27, 2015
Closed
@simon-weber simon-weber mentioned this issue Dec 16, 2015
Closed
@simon-weber
Copy link
Owner Author

Google's interface supports absolute mass-reordering now, which makes this so much easier to implement. I was afraid I was going to have to send O(n) requests per playlist (which I had a trick for optimizing in gmusicapi but never finished).

I'll knock this out for the next release.

@simon-weber simon-weber mentioned this issue Jan 17, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simon-weber