This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Added a back button to the playlist editor to return without saving #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool; thanks! I'm a little hesitant to add more buttons there, though. Thoughts on styling it like the removal links instead? I figure that'd make it less visually prominent, and it mostly matches what they do (a destructive action). A mockup with a random playlist of mine:
|
|
I definitely get what you're saying. I'll update the pull request tonight. |
|
Thanks! I also matched the class to the other links. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a small change. Just trying to work my way through the codebase to understand everything a bit better. I've always kind of wanted a button on the playlist editor that makes it clear you can go back without saving so I went ahead and added one. You can reject the PR if you don't like the idea or just let me know if there is a different way you'd want it implemented.