Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drizzle Integration #28

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Conversation

nickreynolds
Copy link
Contributor

  • Integrating Drizzle into front-end for contract state management / interaction
  • Ran 'truffle unbox drizzle' and made a few changes to get it to display information about migrated contracts
  • This is my first time messing around with Drizzle, so possible that it's not set up 100% correctly
  • Due to monorepo setup, we have to copy contract artifacts from contract package build folder into front-end package source folder (since front-end can't access files in other package). We should consider changing our project structure to match the truffle drizzle default (not a monorepo with packages) so that the copying of files isn't necessary.

… in transactions. There's a PR open to include this functionality in drizzle-react-components but it's not merged in yet.

fixing spelling, allow any text for button

cleanup

fix index.html

fix manifest

removing test, updating gitignore
@simondlr
Copy link
Collaborator

simondlr commented Jul 3, 2018

Awesome. I've been meaning to give Drizzle a spin too. I want to play with this tomorrow a bit!

@tarrencev what do you think of moving back to truffle default vs a monorepo. Playing with monorepos is also on my to-do list, so not 100% sure on advantages/disadvantages.

I'll leave this repo open for now @nickreynolds if that's fine. Give it a day or two. :)

@tarrencev
Copy link
Collaborator

Just getting to this now, sorry for the delay was on vacation.

It seems this is still a monorepo, since we still have a separate package for the frontend. Which I think makes things easier to maintain.

This switches from using the "create-react-app" boilerplate to "drizzle-box", which is an extension of "create-react-app". I've played around with Drizzle a bit in the past and it provides a decent abstraction. I ended up migrating off of it, mostly because it didn't support multiple contract instances (which might have changed) but also since I prefer the more canonical redux pattern of action dispatching.

Overall I think this is fine, keeps us moving in the right direction 👍

@simondlr simondlr merged commit 6a609a4 into artonomous:master Jul 10, 2018
@simondlr
Copy link
Collaborator

Cool. Merging for now. :)

@simondlr
Copy link
Collaborator

Also. Welcome back @tarrencev! Hope the holiday was fun.

@tarrencev
Copy link
Collaborator

Thanks @simondlr :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants