Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript Support #5

Closed
JTongay opened this issue May 21, 2019 · 5 comments
Closed

TypeScript Support #5

JTongay opened this issue May 21, 2019 · 5 comments

Comments

@JTongay
Copy link
Contributor

JTongay commented May 21, 2019

Are there any plans for TypeScript support or at least just a definitions file for now?
@simoneb
Copy link
Owner

simoneb commented May 21, 2019

Not really, also I don't use TypeScript so I'm not the best to create those definitions, but they should be fairly simple to implement. A PR would be welcome :)

@JTongay
Copy link
Contributor Author

JTongay commented May 22, 2019

Cool! I'll start working on it. Shouldn't take too long

@JTongay
Copy link
Contributor Author

JTongay commented Jun 20, 2019 •
edited
Loading

#11 Here are the typings. Ran into a lot of weirdness in linking packages from npm/yarn, sorry it took a while

@simoneb
Copy link
Owner

simoneb commented Jun 20, 2019

Addressed in #11

@simoneb simoneb closed this as completed Jun 20, 2019
@8enSmith 8enSmith mentioned this issue Jul 16, 2019
Merged
@8enSmith
Copy link
Contributor

I found that the typings were missing the definition for the optional "options" parameter. I've created the PR above to update the TypeScript typings to include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simoneb @8enSmith @JTongay