Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error is not reset if subsequent request succeeds #8

Closed
stevewillard opened this issue Jun 7, 2019 · 4 comments
Closed

error is not reset if subsequent request succeeds #8

stevewillard opened this issue Jun 7, 2019 · 4 comments

Comments

@stevewillard
Copy link

If you make a request and it returns an error, and then make a new request, it won't reset error.

I think it's just a matter of resetting error during REQUEST_START.
@simoneb
Copy link
Owner

simoneb commented Jun 7, 2019

thanks for reporting @stevewillard. can you submit a PR for this perhaps?

@stevewillard
Copy link
Author

Sure, I'll take a stab at it when I get a chance.

@8enSmith 8enSmith mentioned this issue Jul 11, 2019
Merged
@8enSmith
Copy link
Contributor

Sure, I'll take a stab at it when I get a chance.

I encountered the same issue and decided to create a PR to fix it. Pretty sure it fixes the issue (test proves the case anyhow!). Another set of eyes reviewing the PR wont harm.

@simoneb
Copy link
Owner

simoneb commented Jul 12, 2019

closed via #15 and fixed in version 1.1.3

@simoneb simoneb closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevewillard @simoneb @8enSmith