Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on GitHub via haskell-ci github happy.cabal #196

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Jul 14, 2021

Out-of-the box CI on GitHub using the haskell-ci tool, put patched for happy, similar to haskell/alex#189.

  • DEVELOPER.md explains how to regenerate the CI, e.g. in case of new GHCs.

  • .github/haskell-ci.patch modifies the generated workflow by:

    • Setting flag 'bootstrap' to False in calls to cabal.
    • Installing happy instead of just building it.
    • Setting HAPPY and HC for running the tests.
  • tests/Makefile has been modified to not overwrite already set HAPPY and HC variables. This is needed to locate these executables correctly.

  • cabal.haskell-ci contains configuration for running haskell-ci:
    It removes constraints on packages containers, mtl and transformers.
    Otherwise, these will be constrained to the GHC-shipped versions, which isn't compatible with happy for all GHC versions.

[fixes #189] [fixes #193]

Get CI on GitHub Actions via a patched workflow generated by haskell-ci.

- DEVELOPER.md explains how to regenerate the CI, e.g. in case of new GHCs.

- .github/haskell-ci.patch modifies the generated workflow by:
  * Setting flag 'bootstrap' to False in calls to cabal.
  * Installing happy instead of just building it.
  * Setting HAPPY and HC for running the tests.

- tests/Makefile has been modified to not overwrite already set HAPPY
  and HC variables.  This is needed to locate these executables correctly.

- cabal.haskell-ci contains configuration for running haskell-ci:
  It removes constraints on packages containers, mtl and transformers.
  Otherwise, these will be constrained to the GHC-shipped versions,
  which isn't compatible with happy for all GHC versions.

The logic behind this CI setup is identical to

  haskell/alex#189

[fixes haskell#189] [fixes haskell#193]
@andreasabel
Copy link
Member Author

@andreasabel andreasabel marked this pull request as ready for review July 14, 2021 18:26
@Ericson2314
Copy link
Collaborator

Can you delete Travis too?

@Ericson2314
Copy link
Collaborator

I emailed @simonmar and @int-index about enabling GitHub actions in this repo.

@Ericson2314 Ericson2314 mentioned this pull request Jul 19, 2021
@andreasabel
Copy link
Member Author

Can you delete Travis too?

Avec plaisir. Voila!

I emailed @simonmar and @int-index about enabling GitHub actions in this repo.

Good. I do not fully understand how this works, but it could be that the actions run as soon as they are in master...

@Ericson2314
Copy link
Collaborator

Oh right, that might be how it was before. Well, taking the risk :).

@Ericson2314 Ericson2314 merged commit 0e6038f into haskell:master Jul 21, 2021
@andreasabel
Copy link
Member Author

Oh right, that might be how it was before. Well, taking the risk :).

Great, that worked: https://github.com/simonmar/happy/actions/runs/1050964788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

travis-ci.org shutdown Switch to Github Workflows for CI?
2 participants