Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI workflow to standard haskell-ci workflow #284

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

sgraf812
Copy link
Collaborator

The simpler, the better.

@sgraf812 sgraf812 force-pushed the wip/update-ci branch 4 times, most recently from 29818c3 to 6464c86 Compare July 15, 2024 12:50
@sgraf812 sgraf812 force-pushed the wip/update-ci branch 18 times, most recently from 349a237 to 47f12b6 Compare July 22, 2024 17:23
@sgraf812
Copy link
Collaborator Author

sgraf812 commented Jul 22, 2024

I'm not completely sure what changed since I tried something similar in #279, but now the vanilla CI workflow generated by haskell-ci just works.

It seems that our previous logic in tests/Makefile to set HAPPY was simply too smart for its own good.

I would be happy for @andreasabel to take a brief look, because he came up with the setup in #196. I verified that we indeed test the correct happy version which adding a dummy Makefile target path.run which outputs

--> Printing happy path...
which happy
/__w/happy/happy/dist-newstyle/build/x86_64-linux/ghc-8.6.5/happy-2.0/x/happy/build/happy/happy

@andreasabel
Copy link
Member

Excellent!
Seem that time has made my workaround superfluous.
(Also, this was a few years back, now I have a better understanding of all the cabal workings and pitfalls.)

@sgraf812 sgraf812 merged commit 10a0fe5 into master Jul 22, 2024
26 checks passed
@sgraf812 sgraf812 deleted the wip/update-ci branch July 22, 2024 18:01
@sgraf812
Copy link
Collaborator Author

Thanks. I think your approach was necessary back when we still had the +bootstrap flag, but that was removed in #277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants